Skip to content

PDFBOX-5284: Refactor Refactor PDFTabulaTextStripper to improve test …#130

Open
wx930910 wants to merge 1 commit intoapache:trunkfrom
wx930910:PDFBOX-5284
Open

PDFBOX-5284: Refactor Refactor PDFTabulaTextStripper to improve test …#130
wx930910 wants to merge 1 commit intoapache:trunkfrom
wx930910:PDFBOX-5284

Conversation

@wx930910
Copy link

Jira

Description

Replace test class PDFTabulaTextStripper by spying object and improve test design


Motivation
  • Decouple test class PDFTabulaTextStripper from production class PDFTextStripper.
  • Remove the redundant test child class PDFTabulaTextStripper
  • Remove the redundant constructor.

Key changed/added classes in this PR
  • Created spying object to replace test subclass PDFTabulaTextStripper, decoupled test from production code.
  • Created method that return the mocking object for code reuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant