feat(services/s3): Add AWS container credentials support for ECS and EKS Pod Identity#7166
Open
rohankmr414 wants to merge 1 commit intoapache:mainfrom
Open
feat(services/s3): Add AWS container credentials support for ECS and EKS Pod Identity#7166rohankmr414 wants to merge 1 commit intoapache:mainfrom
rohankmr414 wants to merge 1 commit intoapache:mainfrom
Conversation
…EKS Pod Identity Add support for AWS container credentials to enable authentication in containerized environments: - ECS Task IAM roles - EKS Pod Identity - AWS Fargate - Custom container credential endpoints Changes: - Add 5 new configuration fields to S3Config with AWS-prefixed aliases - Add 5 builder methods to S3Builder for container credentials - Integrate ECSCredentialProvider into credential chain - Add comprehensive tests for configuration parsing - Add detailed documentation for ECS and EKS Pod Identity usage The implementation uses reqsign-aws-v4's ECSCredentialProvider which supports both ECS and EKS Pod Identity through standard AWS container credential environment variables. Related to PR apache#6525
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for AWS container credentials to enable authentication in containerized environments:
Changes:
The implementation uses reqsign-aws-v4's ECSCredentialProvider which supports both ECS and EKS Pod Identity through standard AWS container credential environment variables.
Related to PR #6525
Rationale for this change
This PR adds support for AWS container credentials to enable S3 authentication in containerized environments, specifically for ECS Task IAM roles and EKS Pod Identity. This was originally proposed in PR #6525 but was blocked waiting for reqsign v0.17.0+ which included the
ECSCredentialProvider. Since the codebase now uses reqsign-aws-v4 v2.0.2 (which includes this provider), we can now implement this feature.What changes are included in this PR?
Configuration fields: Added 5 new fields to
S3Configfor container credentials:container_credentials_relative_uri- For ECS Task IAM rolescontainer_credentials_endpoint- For EKS Pod Identity and Fargatecontainer_authorization_token- Authorization token for credential requestscontainer_authorization_token_file- Path to authorization token file (required for EKS Pod Identity)container_metadata_uri_override- Override for metadata endpoint (for testing)Builder methods: Added 5 corresponding builder methods to
S3Builderfor programmatic configurationCredential provider integration: Integrated
ECSCredentialProviderfrom reqsign-aws-v4 into the credential chain, positioned after static credentials but before assume role providerTests: Added comprehensive test cases to verify configuration parsing with both standard and AWS-prefixed field name aliases
Are there any user-facing changes?
Yes - This PR adds new public API methods and configuration options:
New builder methods:
S3Builder::container_credentials_relative_uri()S3Builder::container_credentials_endpoint()S3Builder::container_authorization_token()S3Builder::container_authorization_token_file()S3Builder::container_metadata_uri_override()New configuration fields:
container_credentials_relative_uri(alias:aws_container_credentials_relative_uri)container_credentials_endpoint(aliases:container_credentials_full_uri,aws_container_credentials_full_uri)container_authorization_token(alias:aws_container_authorization_token)container_authorization_token_file(alias:aws_container_authorization_token_file)container_metadata_uri_override(aliases:aws_container_metadata_uri_override,aws_metadata_endpoint,metadata_endpoint)No breaking changes - All new fields are optional and the credential provider chain maintains backward compatibility.
AI Usage Statement
This PR was developed with assistance from Augment Agent (Claude Sonnet 4.5 by Anthropic) for code implementation, testing, and documentation.