Open
Conversation
PragmaTwice
requested changes
Feb 9, 2026
Member
PragmaTwice
left a comment
There was a problem hiding this comment.
The format design in this PR is not compatible with Redis at all. Not even close. Please ensure that you understand the design and the code.
Contributor
Author
|
@PragmaTwice , Thank you for pointing this out, I will take this as learning and will do a proper implementation |
- Map JSON type to RDBTypeString (type 0) for Redis compatibility - Serialize JSON to string representation during DUMP - RESTORE creates String type (similar to SortedInt → Set pattern) - Add TestDump_JSON following existing test patterns - Type changes: ReJSON-RL → string after RESTORE (trade-off for compatibility)
08d5635 to
2e027c0
Compare
Contributor
Author
|
From next time for these types can i just combine 2-3 type in a pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Redis-compatible DUMP/RESTORE support for JSON type using type coercion approach.
Maps JSON objects to Redis String type (RDBTypeString) during serialization, preserving data while maintaining full Redis compatibility. Similar to how SortedInt coerces to Set.
Closes #3319
Changes
Implementation Approach
kRedisJson→RDBTypeStringjson_db.Get(), dumps to string, saves viaSaveStringObject()Trade-offs
string(notReJSON-RL)JSON.SETto restore JSON functionalityThis matches the pattern used for SortedInt (which becomes Set after RESTORE).
Testing
Manual Testing