Skip to content

fix(transaction): preserve delete-only manifests in fast_append #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drbothen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(transaction): preserve delete-only manifests in fast_append #2149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/iceberg/src/transaction/append.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,16 @@ impl SnapshotProduceOperation for FastAppendOperation {
)
.await?;

// Delete-only manifests must be preserved so that subsequent scans
// can see which file paths were removed (e.g. by a rewrite_files
// operation). Dropping them causes deleted files to reappear as
// alive in the next snapshot.
Ok(manifest_list
.entries()
.iter()
.filter(|entry| entry.has_added_files() || entry.has_existing_files())
.filter(|entry| {
entry.has_added_files() || entry.has_existing_files() || entry.has_deleted_files()
})
.cloned()
.collect())
}
Expand Down
Loading