[helm] Enable pulling from private Docker registry#2692
Open
affo wants to merge 1 commit intoapache:mainfrom
Open
[helm] Enable pulling from private Docker registry#2692affo wants to merge 1 commit intoapache:mainfrom
affo wants to merge 1 commit intoapache:mainfrom
Conversation
affo
force-pushed
the
la-pull-secrets
branch
from
4ac5e0d to
8cd11e5
Compare
xx789633
reviewed
Feb 19, 2026
| Image name | ||
| */}} | ||
| {{- define "fluss.image" -}} | ||
| {{- $image := printf "%s:%s" .Values.image.repository .Values.image.tag }} |
Contributor
There was a problem hiding this comment.
If a user omits image.tag or sets it to empty, this would produce an invalid image reference like apache/fluss:. Maybe we need to add a fallback here.
| Image name | ||
| */}} | ||
| {{- define "fluss.image" -}} | ||
| {{- $image := printf "%s:%s" .Values.image.repository .Values.image.tag }} |
Contributor
There was a problem hiding this comment.
If a user provides a purely numeric tag (e.g. tag: 1.0), printf "%s" in Helm may output apache/fluss:%!s(float64=1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2691
Brief change log
images.registryimage.pullSecretsMakes it possible to use an alternate registry and use pull secrets to pull the image if the registry is private.
I favored the approach of adding pull secrets directly to STS and not in the service account for bigger flexibility as the user can still link another service account to pods while pull secrets are attached to pods.
Tests
No test introduced.
Would be good to add tests once this PR lands (introduces
helm unittest+ github workflow).API and Format
NO
Documentation
No new feature, it is already documented in the README.