fix(spark) CTAS with UNION in Spark 4.x native writer#3524
Open
Shekharrajak wants to merge 1 commit intoapache:mainfrom
Open
fix(spark) CTAS with UNION in Spark 4.x native writer#3524Shekharrajak wants to merge 1 commit intoapache:mainfrom
Shekharrajak wants to merge 1 commit intoapache:mainfrom
Conversation
Shekharrajak
changed the title
Shekharrajak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3429
Rationale for this change
CTAS with UNION fails in Spark 4.x when the Comet native writer is enabled. The
requiresNativeChildrencheck inCometExecRulewas too strict - it required children to beCometNativeExec, but sink operators likeCometUnionExec,CometCoalesceExec,CometCollectLimitExecextendCometExecdirectly while still producing Arrow-formatted data.What changes are included in this PR?
CometNativeExectoCometExecinCometExecRule.convertToComet()to allow all Comet operators that produce Arrow-formatted data as input to the native writer.How are these changes tested?
Added 6 new test cases in
CometParquetWriterSuite: