feat: add support for aes_decrypt expression#3497
Open
rafafrdz wants to merge 15 commits intoapache:mainfrom
Open
feat: add support for aes_decrypt expression#3497rafafrdz wants to merge 15 commits intoapache:mainfrom
aes_decrypt expression#3497rafafrdz wants to merge 15 commits intoapache:mainfrom
Conversation
rafafrdz
force-pushed
the
feat/add-support-aes_decrypt
branch
from
3b7cc7f to
eb318d1
Compare
andygrove
reviewed
Feb 13, 2026
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
Outdated
Show resolved
Hide resolved
…s_decrypt # Conflicts: # native/spark-expr/src/comet_scalar_funcs.rs
Member
|
Thanks for the contribution @rafafrdz. I took a quick look and this looks nice. I kicked off CI. On the testing side, the current tests only cover GCM mode with a 256-bit key. Since the Rust implementation also supports CBC and ECB modes with PKCS padding, and handles 128-bit, 192-bit, and 256-bit keys, it would be great to add test coverage for those combinations. It might also be worth adding a null input test, maybe inserting a row with null encrypted data and verifying the result is null. |
…to feat/add-support-aes_decrypt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aes_decryptby mapping AesDecrypt to native scalar functionaes_decrypt.Closes [Feature] Support Spark expression: aes_decrypt #3188