chore(infra): remove build-macos-x86_64 by kevinjqliu · Pull Request #1325 · apache/datafusion-ballista

kevinjqliu · 2025-10-04T21:30:47Z

Which issue does this PR close?

Closes #.

Rationale for this change

~~Follow up to #1324, the correct replacement for macos-13 should be macos-15-intel for Intel-based architecture~~
according to
https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Since both build-python-mac-win and build-macos-x86_64 use macos-latest, we can consolidate and refactor the steps to run for individual os

What changes are included in this PR?

Are there any user-facing changes?

kevinjqliu · 2025-10-05T16:50:51Z

@milenkovicm please take a look

milenkovicm

Personally I don't think we should care about Intel Macs at this stage, latest makes more sense to me

milenkovicm · 2025-10-05T18:30:01Z

.github/workflows/build.yml

    needs: [generate-license]
    name: Mac x86_64
-    runs-on: macos-latest
+    runs-on: macos-15-intel


I'm not sure, why would we test it on intel chipset, arm (latest) makes more sense to me

making this change because this was originally using macos-13
macos-15-intel is the direct replacement

the name of the step "Mac x86_64" suggest that we should use an intel based processor.

macos-latest is arm64
https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories

opened this pr to correct the mistake from #1324
we can follow up with removing this github action step is necessary

I believe intel architecture for Mac is on its way out, let's keep arm, and just rename action, Wdyt?

i remove the build-macos-x86_64 step entirely, the step above, build-python-mac-win, already covers mac-latest

can we rename

build-macos-x86_64: needs: [generate-license] name: Mac x86_64 runs-on: macos-latest

build-macos-x86_64 -> build-macos-arm64

so instead of removing build-macos-x86_64, we want to just rename to build-macos-arm64?

kevinjqliu · 2025-10-16T00:54:33Z

@milenkovicm i updated the pr to split out windows and mac. lmk if this is what you were thinking about

milenkovicm · 2025-10-16T19:23:47Z

.github/workflows/build.yml

          path: python/target/wheels/*

-  build-macos-x86_64:
+  build-macos-arm64:


this is what i was asking, as name changed after you push update to use arm64 👍🏻

milenkovicm · 2025-10-16T19:24:39Z

.github/workflows/build.yml

          path: LICENSE.txt

-  build-python-mac-win:
+  build-windows:


I'm not sure why you removed mac from here? is there other job which tests this python on mac

yes, build-macos-arm64.

build-python-mac-win used to run for windows and macos. but since build-macos-arm64 already runs for macos, im chaning this to just run windows.

build-python-mac-win builds ballista/python/ extension, on the other hand build-macos-arm64 builds core ballista/ or I'm missing something

heres a side by side diff of build-python-mac-win and build-macos-arm64 taken from latest main

datafusion-ballista/.github/workflows/build.yml

Lines 108 to 213 in 400f818

build-python-mac-win:

needs: [generate-license]

name: Mac/Win

runs-on: ${{ matrix.os }}

strategy:

fail-fast: false

matrix:

python-version: ["3.10"]

os: [macos-latest, windows-latest]

steps:

- uses: actions/checkout@v5

- uses: actions/setup-python@v5

with:

python-version: ${{ matrix.python-version }}

- uses: dtolnay/rust-toolchain@stable

- run: rm LICENSE.txt

- name: Download LICENSE.txt

uses: actions/download-artifact@v4

with:

name: python-wheel-license

path: .

- name: Install Protoc

uses: arduino/setup-protoc@v3

with:

version: "27.4"

repo-token: ${{ secrets.GITHUB_TOKEN }}

- uses: astral-sh/setup-uv@v6

with:

enable-cache: true

- name: Build Python package

run: |

cd python

uv sync --dev --no-install-package ballista

uv run --no-project maturin build --release --strip

- name: List Windows wheels

if: matrix.os == 'windows-latest'

run: dir python\target\wheels\

# since the runner is dynamic shellcheck (from actionlint) can't infer this is powershell

# so we specify it explicitly

shell: powershell

- name: List Mac wheels

if: matrix.os != 'windows-latest'

run: find python/target/wheels/

- name: Archive wheels

uses: actions/upload-artifact@v4

with:

name: dist-${{ matrix.os }}

path: python/target/wheels/*

build-macos-x86_64:

needs: [generate-license]

name: Mac x86_64

runs-on: macos-latest

strategy:

fail-fast: false

matrix:

python-version: ["3.10"]

steps:

- uses: actions/checkout@v5

- uses: actions/setup-python@v5

with:

python-version: ${{ matrix.python-version }}

- uses: dtolnay/rust-toolchain@stable

- run: rm LICENSE.txt

- name: Download LICENSE.txt

uses: actions/download-artifact@v4

with:

name: python-wheel-license

path: .

- name: Install Protoc

uses: arduino/setup-protoc@v3

with:

version: "27.4"

repo-token: ${{ secrets.GITHUB_TOKEN }}

- uses: astral-sh/setup-uv@v6

with:

enable-cache: true

- name: Build Python package

run: |

cd python

uv sync --dev --no-install-package ballista

uv run --no-project maturin build --release --strip

- name: List Mac wheels

run: find python/target/wheels/

- name: Archive wheels

uses: actions/upload-artifact@v4

with:

name: dist-macos-aarch64

path: python/target/wheels/*

the only difference is which os is running. the refactor here is to get rid of the matrix.os in build-python-mac-win since build-macos-x86_64 is already running for macos-latest

milenkovicm reviewed Oct 5, 2025

View reviewed changes

kevinjqliu changed the title ~~infra: use macos-15-intel for x86_64~~ infra: remove build-macos-x86_64 Oct 12, 2025

split windows and mac build

3b412e1

kevinjqliu force-pushed the patch-1 branch from 5076a3e to 3b412e1 Compare October 16, 2025 00:45

windows-x86_64

63ed1bc

milenkovicm reviewed Oct 16, 2025

View reviewed changes

milenkovicm changed the title ~~infra: remove build-macos-x86_64~~ chore(infra): remove build-macos-x86_64 Oct 30, 2025

	build-python-mac-win:
	needs: [generate-license]
	name: Mac/Win
	runs-on: ${{ matrix.os }}
	strategy:
	fail-fast: false
	matrix:
	python-version: ["3.10"]
	os: [macos-latest, windows-latest]
	steps:
	- uses: actions/checkout@v5

	- uses: actions/setup-python@v5
	with:
	python-version: ${{ matrix.python-version }}

	- uses: dtolnay/rust-toolchain@stable

	- run: rm LICENSE.txt
	- name: Download LICENSE.txt
	uses: actions/download-artifact@v4
	with:
	name: python-wheel-license
	path: .

	- name: Install Protoc
	uses: arduino/setup-protoc@v3
	with:
	version: "27.4"
	repo-token: ${{ secrets.GITHUB_TOKEN }}

	- uses: astral-sh/setup-uv@v6
	with:
	enable-cache: true

	- name: Build Python package
	run: \|
	cd python
	uv sync --dev --no-install-package ballista
	uv run --no-project maturin build --release --strip

	- name: List Windows wheels
	if: matrix.os == 'windows-latest'
	run: dir python\target\wheels\
	# since the runner is dynamic shellcheck (from actionlint) can't infer this is powershell
	# so we specify it explicitly
	shell: powershell

	- name: List Mac wheels
	if: matrix.os != 'windows-latest'
	run: find python/target/wheels/

	- name: Archive wheels
	uses: actions/upload-artifact@v4
	with:
	name: dist-${{ matrix.os }}
	path: python/target/wheels/*

	build-macos-x86_64:
	needs: [generate-license]
	name: Mac x86_64
	runs-on: macos-latest
	strategy:
	fail-fast: false
	matrix:
	python-version: ["3.10"]
	steps:
	- uses: actions/checkout@v5

	- uses: actions/setup-python@v5
	with:
	python-version: ${{ matrix.python-version }}

	- uses: dtolnay/rust-toolchain@stable

	- run: rm LICENSE.txt
	- name: Download LICENSE.txt
	uses: actions/download-artifact@v4
	with:
	name: python-wheel-license
	path: .

	- name: Install Protoc
	uses: arduino/setup-protoc@v3
	with:
	version: "27.4"
	repo-token: ${{ secrets.GITHUB_TOKEN }}

	- uses: astral-sh/setup-uv@v6
	with:
	enable-cache: true

	- name: Build Python package
	run: \|
	cd python
	uv sync --dev --no-install-package ballista
	uv run --no-project maturin build --release --strip

	- name: List Mac wheels
	run: find python/target/wheels/

	- name: Archive wheels
	uses: actions/upload-artifact@v4
	with:
	name: dist-macos-aarch64
	path: python/target/wheels/*

Comments

Conversation

kevinjqliu commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Uh oh!

kevinjqliu commented Oct 5, 2025

Uh oh!

milenkovicm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kevinjqliu commented Oct 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kevinjqliu Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kevinjqliu commented Oct 4, 2025 •

edited

Loading

kevinjqliu Oct 25, 2025 •

edited

Loading