Fix NPE during reset password

[sureshanaparti]

Description

This PR fixes the NPE during reset password, and has some code improvements. Failed to throw proper error when there is no session while resetting password.

Fixes #12582

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[codecov]

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (9ae696d) to head (1001510).

Files with missing lines	Patch %	Lines
...ack/api/command/SAML2LoginAPIAuthenticatorCmd.java	0.00%	6 Missing ⚠️
...loud/api/auth/DefaultLoginAPIAuthenticatorCmd.java	0.00%	3 Missing ⚠️
server/src/main/java/com/cloud/api/ApiServlet.java	0.00%	1 Missing and 1 partial ⚠️
...th2/api/command/OauthLoginAPIAuthenticatorCmd.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12585      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
  Complexity    13428    13428              
============================================
  Files          5660     5660              
  Lines        499963   499965       +2     
  Branches      60708    60709       +1     
============================================
  Hits          81330    81330              
- Misses       409559   409562       +3     
+ Partials       9074     9073       -1     

Flag	Coverage Δ
uitests	4.16% <ø> (ø)
unittests	17.12% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sudo87]

clgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16706

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-15383)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57460 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12585-t15383-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_LoginApiDomain	Error	7.10	test_accounts.py