AVRO-4135: [Java] JSON decoding unqualified union types#3374
Open
steven-aerts wants to merge 1 commit intoapache:mainfrom
Open
AVRO-4135: [Java] JSON decoding unqualified union types#3374steven-aerts wants to merge 1 commit intoapache:mainfrom
steven-aerts wants to merge 1 commit intoapache:mainfrom
Conversation
Support unqualified type references for unions when decoding them from json. AVRO-2287 makes it unclear if type reference for a JSON encoded union needs to be qualified or not. Today all encoders use the fully qualified types except the C JSON encoder which uses the unqualified type. In this patch we make the java JSON Decoder more lenient and let it fallback to unqualified types names when no qualified type name matches. Which matches the behavior currently implemented in the Javascript Json decoder. This patch is an alternative for apache#3373 where it is proposed to update the C library instead.
opwvhk
requested changes
May 29, 2025
Contributor
opwvhk
left a comment
opwvhk
left a comment
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support unqualified type references for unions when decoding them from json.
AVRO-2287 makes it unclear if type reference for a JSON encoded union needs to be qualified or not.
Today all encoders use the fully qualified types except the C JSON encoder which uses the unqualified type.
In this patch we make the java JSON Decoder more lenient and let it fallback to unqualified types names when no qualified type name matches. Which matches the behavior currently implemented in the Javascript Json decoder.
This patch is an alternative for #3373 where it is proposed to update the C library instead.
Verifying this change
This change added tests and can be verified as follows: run newly added test:
org.apache.avro.io.TestJsonDecoder#testUnionTypeQualificationDocumentation