Fix MutableArrayData::extend for ListView#9562
Open
vegarsti wants to merge 4 commits intoapache:mainfrom
Open
Conversation
MutableArrayData's build_extend for ListView/LargeListView copies offsets and sizes from the source array but never extends the child data. This produces invalid arrays where offsets reference nonexistent child elements, causing panics on access.
brancz
approved these changes
Mar 16, 2026
| // Copy the child range | ||
| let child_base = if child_max > child_min { | ||
| let base = mutable.child_data[0].len(); | ||
| mutable.child_data[0].extend(index, child_min, child_max); |
Contributor
Author
There was a problem hiding this comment.
Are you referring to extend_with_slice?
Contributor
Author
There was a problem hiding this comment.
No, probably the slice operation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9561.
The existing implementation in list_view.rs copies offsets and sizes but skips copying child data. The original code copies offsets and sizes into a new array that has an empty child values array, so the offsets may point into nothing if the child data doesn't exist anymore.