fix: Write zero-filled values buffer for fully-null Bool columns in IPC#392
Open
AlonSpivack wants to merge 1 commit intoapache:mainfrom
Open
fix: Write zero-filled values buffer for fully-null Bool columns in IPC#392AlonSpivack wants to merge 1 commit intoapache:mainfrom
AlonSpivack wants to merge 1 commit intoapache:mainfrom
Conversation
When a Bool column has nullCount >= length, VectorAssembler now writes a zero-filled buffer of ((length + 7) >> 3) bytes instead of skipping the values buffer entirely. This ensures compliance with the Arrow IPC spec and cross-language compatibility with PyArrow and arrow-rs. Closes apache#68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Bool column is fully null (
nullCount >= length),assembleBoolVectorinVectorAssemblerpreviously returned early without writing a values buffer,producing an IPC stream with 0 bytes for buffer
#1.This violates the Arrow IPC specification, which requires a data buffer of
ceil(length / 8)bytes for Bool arrays regardless of null count. Otherimplementations (PyArrow, arrow-rs) reject these streams with:
Fix
Write a zero-filled
Uint8Arrayof the correct byte length((data.length + 7) >> 3)when all values are null, instead of returning early with no buffer.
Tests
Added 4 round-trip tests for fully-null Bool columns through
tableToIPC/tableFromIPC:Closes #68
cc @trxcllnt @domoritz