feat(format): add more constraint metadata to GetObjects#4008
Open
lidavidm wants to merge 3 commits intoapache:spec-1.2.0from
Open
feat(format): add more constraint metadata to GetObjects#4008lidavidm wants to merge 3 commits intoapache:spec-1.2.0from
lidavidm wants to merge 3 commits intoapache:spec-1.2.0from
Conversation
lidavidm
changed the title
constraint_expression to GetObjects
zeroshade
reviewed
Feb 21, 2026
amoeba
reviewed
Feb 23, 2026
paleolimbot
approved these changes
Feb 27, 2026
Member
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
I can't speak to the constants but the update to the schema seems reasonable/seems like it won't break existing clients.
Comment on lines
+639
to
+643
| /// \brief This foreign key allows any of the foreign key columns to be NULL; | ||
| /// if so, no match is required in the referenced table. | ||
| /// | ||
| /// \see AdbcConnectionGetObjects | ||
| #define ADBC_CONSTRAINT_MATCH_SIMPLE 0 |
Member
There was a problem hiding this comment.
Do the ADBC_CONSTRAINT_MATCH_* constants have JDBC sources or some other citation as to why they're needed?
Member
Author
There was a problem hiding this comment.
They are technically part of ANSI SQL and are somewhat supported in PostgreSQL, but only for SIMPLE and FULL. Unfortunately ANSI SQL isn't publicly available...
JDBC does not surface this information. Match type was requested in point 12 here: #3971 (GitHub apparently doesn't support linking to subheadings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constraint_expressionCloses #3987.
Closes #3989.