[WIP] Refactor AMQ3529v2Test to improve thread handling and logging consistency #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanouii
changed the title
jbonofre
approved these changes
Feb 4, 2026
jbonofre
reviewed
Feb 4, 2026
| if (t == null || !t.isAlive() || t.isDaemon()) { | ||
| continue; | ||
| } | ||
| if (t.getName().startsWith("ActiveMQ Transport")) { |
Member
There was a problem hiding this comment.
Let me check if it's good enough for transport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We strictly enforce client threads to be finished.
The Transport thread assertion is relaxed and logged as WARN for the moment after giving it more time to complete.
Transport cleanup can be a bit delayed. We might want to still assert the transport threads to avoid any regression.