Bump org.apache.zookeeper:zookeeper from 3.9.4 to 3.9.5#6205
Closed
dependabot[bot] wants to merge 2365 commits into2.1from
Closed
Bump org.apache.zookeeper:zookeeper from 3.9.4 to 3.9.5#6205dependabot[bot] wants to merge 2365 commits into2.1from
dependabot[bot] wants to merge 2365 commits into2.1from
Conversation
* Restore test case for ensuring experimental annotation works properly on an experimental property
…#5822) * Remove Utils.getTableNameLock() and all places it was used * Add test cases with concurrent operations to ensure the places that the locks were removed handle things properly without the locks
When calling TableOperations.getTabletInformation() it currently retrieves a lot of tablet metadata. If this information is not of interest then a lot of time could be spent gathering information that is never used (especially for the per tablet file data). Modified TableOperations.getTabletInformation() to allow specifying a subset of tablet metadata to fetch.
…5775) The new resource group parameter has been added in anticipation of the resource operations api addition in #5749. This change also adds a debug system property like we have for hosts that allows the user to configure the client to only connect to hosts in the resource group for non-management api operations. Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
making it such that there were no ITs that get run as part of SimpleSharedMacTestSuiteIT with the sunny profile. This caused the sunny profile test run to fail because the SimpleSharedMacTestSuiteIT would not find any tests to run and fail. Adding the sunny tag to one test that runs as part of the suite fixes the issue. Closes #5851
Closes #4537 Co-authored-by: Kevin Rathbun <kevinrr888@gmail.com>
This change adds support for persistent configurations for Resource Groups. On instance upgrade or initialization the /resource_groups path is created in ZooKeeper and the default resource group node is created /resource_groups/default. AccumuloClient.resourceGroupOperations() returns an instance of ResourceGroupOperations which has methods for creating and removing Resource Group configuration nodes and for setting, modifying, and deleting properties. The Shell config command, zoo-prop-viewer and zoo-prop-editor have been modified to accept Resource Group arguments. Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
* FATE config changes
changes the FATE config structure
From:
* being a JSON where each key is a comma-separated list of FATE operations and each value is a pool size for those operations
To:
* being a JSON where each key is some user-defined name and each value is a JSON with a single key/value where the key is a comma-separated list of FATE operations and the value is a pool size for those operations
For example:
* {"SOME_OPS": 4, "REMAINING_OPS": 10}
Could become:
* {"pool1": {"SOME_OPS": 4}, "pool2": {"REMAINING_OPS": 10}}
This was done to facilitate some way to maintain metrics for these pools without including the (potentially very long) list of FATE operations, which could be an issue for some monitoring systems. Also shortens some log messages. Instead of the FateExecutor objects only being identifiable by their assigned FATE ops, they are now given the name as defined in the config which can be used to identify them as well.
Previously:
* metrics tags would include all the FATE operations for that pool, but these long metrics could be an issue for some monitoring systems
* the pool name would be "accumulo.pool.manager.fate.[user/meta].[THE OPS]"
* the work finder for the pool would be named "fate.work.finder.[user/meta].[THE OPS]"
Now:
* metrics tags include the name instead of the entire list of operations (tag looks like "accumulo.pool.manager.fate.[user/meta].[THE NAME]")
* the pool name is "accumulo.pool.manager.fate.[user/meta].[THE NAME]"
* the work finder thread for the pool is named "fate.work.finder.[user/meta].[THE NAME]"
closes #5836
* Revert d21fc1b for PR #5852, since #5851 can be fixed with this change instead, without adding a new test to the sunny profile; comprehensive table operations testing is outside the scope of the basic test case that the sunny profile should be limited to doing * Add the `failIfNoTests = false` option to the `@Suite` annotation so that it does not fail if some combination of options fails to result in any matching test cases to run (minicluster is still started for the test, though no tests will run; that is addressed by the next change below) * Explicitly run only the regular junit-jupiter engine, and not the junit-platform-suite engine, by default when running the sunny profile, so that it does not execute SimpleSharedMacTestSuiteIT's BeforeSuite and AfterSuite methods, which is a waste of time since that suite does not have any tests with the SunnyDay tag Also: * Move the class so it fits into the module/package naming conventions * Add a CI check for module/package naming conventions for future work More background: The maven-surefire-plugin/maven-failsafe-plugin's JUnit5 provider will use both the normal (non-suite) `junit-jupiter` engine and the `junit-platform-suite` engine. These engines behave differently when handling the surefire/failsafe option to filter tests based on groups. The regular engine will filter tests based on the configured groups by the `@Tag` annotation before executing the tests. The suite engine appears to identify the suites to run first, then filters the test cases contained in that suite by the `@Tag` annotation. While the regular engine's failure to find any tests can be handled by the Maven properties, `(surefire|failsafe).failIfNoSpecifiedTests`, that does not work for the suite engine. Instead, the suite engine requires `@Suite(failIfNoTests = false)` to be used. That will prevent the failure to find tests from failing the build, but it will still execute the suite's `@BeforeSuite` and `@AfterSuite` methods. An additional configuration is needed to explicitly control which engines are executed by surefire/failsafe in order to avoid executing "empty" suites' before/after steps entirely. In Accumulo, we do not have any suite tests that need to run during the `sunny` profile, so we can safely skip the suite engine's execution when activating that profile. We do not want to exclude the engine, though, because that limits the user's ability to override settings on the command-line with an exclude option. So instead, we limit the set of included engines to only the regular one, so users can still override the include/exclude properties to have more granular control, if they wish.
* Workaround generic type inference bug in Eclipse in FateExecutor by adding the generic type explicitly * Remove unused code in RFile and ComprehensiveIT * Remove unclosed resource warning in RangedTableLocksIT for ClientContext variable (false positive in Eclipse, but easy to work around)
Converted from the old java 11 syntax to the improved java 17 instanceof syntax
* Fixed a FunctionalTestUtils method Improves usage of FunctionalTestUtils.getStoredTabletFiles(). Was previously always scanning the METADATA table for stored tablet files of the provided table. This doesn't work if we want the stored tablet files of the METADATA table or the ROOT table, in which case we should be scanning the ROOT table or the root tablet metadata (in ZK), respectively. Used Ample to achieve this. * removed the problematic FunctionalTestUtil method instead Since it is currently unused, removed instead to be added later with fixes if needed
Fixes a race condition where the merge code would not wait for a tablet to be unassigned. Fixes #5870. Used the same strategy as the split code for the fix.
* Fixes several Monitor bugs - Replaced all uses of Thread.onSpinWait() with Thread.sleep() throughout the code. Was being incorrectly used in while loops that were not expected to very quickly change state. Thread.sleep() is more appropriate for these longer waits. The uses of Thread.onSpinWait() would result in very high CPU usage. - Fixed NullPointerException seen in the Monitor. SystemInformation.updateAggregates() needed to check that response.getMetrics() != null. - Monitor homepage would show no data in the "Accumulo Manager" table, "/manager" endpoint would show Manager status as "undefined". Fixed these issues. Navigating through all the monitor pages, all seem to be correct now. Data appears accurate and no Javascript errors in console.
* Add CountDownLatch to concurrent tests to improve concurrency and to be able to choose where the threads sync up in order to better stress the code we are trying to stress * Add assert statements and shared variables to ensure we are properly handling integers and other values that pertain to the correctness of test logic within the changed tests
Removes uses of deprecated Java methods: Thread.suspend() and Thread.resume(). There was only one use: in ZooCacheIT. Was being used to simulate a ZooKeeper disconnect, replaced with the Watcher instead processing a Disconnected event. closes #5846
Now that starting a manager looks like `accumulo proc manager` the correct thing is no longer being passed to the accumulo-env.sh for the `cmd` variable. This was causing logging and other things to not work correctly.
* Refactored PreAllocatedArray.java into a static method * moved method into its own class
ScanServerGroupConfigurationIT was failing because the ConfigurableScanServerSelector only checks for new ScanServers at 5 second intervals and the test was doing a lookup too quickly. The fix for the test is to just wait 5 seconds. This change includes adding trace logging into the ConfigurableScanServerSelector for better debugging and formatting some of the large JSON blocks using Java text blocks. Closes #6154
The manager metrics setup code was spread over multiple classes and functions. Pulled setting up metrics into a single function in the manager. The tablet group watcher metrics code existed in manager code. Pulled TGW metrics code into the TGW code for better encapsulation and simplification of the manger code. * code review update * code review update
…ompactors pages (#6200)
* add banners to pages to let the users know why the status LEDs for each server component is showing ERROR or WARN
Bumps org.apache.zookeeper:zookeeper from 3.9.4 to 3.9.5. --- updated-dependencies: - dependency-name: org.apache.zookeeper:zookeeper dependency-version: 3.9.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Member
|
@dependabot rebase |
Contributor
Author
|
The base commit for this pull request has not changed. |
Member
|
Fixing manually. Dependabot isn't smart enough to rebase onto a different branch. |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/maven/org.apache.zookeeper-zookeeper-3.9.5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps org.apache.zookeeper:zookeeper from 3.9.4 to 3.9.5.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.