Add more browser testing with Sauce Labs.#2
Open
heathkit wants to merge 7 commits intoangular-workshops:solutionfrom
Open
Add more browser testing with Sauce Labs.#2heathkit wants to merge 7 commits intoangular-workshops:solutionfrom
heathkit wants to merge 7 commits intoangular-workshops:solutionfrom
Conversation
cnishina
reviewed
Sep 26, 2016
| sauceUser: process.env.SAUCE_USERNAME, | ||
| sauceKey: process.env.SAUCE_ACCESS_KEY, | ||
|
|
||
| directConnect: false, |
Collaborator
There was a problem hiding this comment.
Instead of trying to override an existing with an Object.assign, could we instead do something like:
var defaultConfig = require('./protractor.conf.js').config;
defaultConfig.directConnect = undefined;
defaultConfig.seleniumAddress = undefined;
defaultConfig.sauceUser
...
exports.config = defaultConfig;
Collaborator
There was a problem hiding this comment.
Also, defaultConfig.capabilities = undefined to get rid of the warning
Collaborator
Author
There was a problem hiding this comment.
Turns out the problem was I was using an old Sauce Labs account, which didn't have any VM minutes for automated testing. Instead of throwing an error, Sauce would just hang forever waiting to launch.
Also, this uncovered a bug in Protractor. The way 'beforeLaunch' is used to set up ts-node doesn't actually work with multiCapabilities, because of the way we fork in the launcher. I suspect that if you used test sharding, that would also break.
4953489 to
e9c713a
Compare
There seems to be an issue with 'beforeLaunch' and multicapabilities that breaks ts-node when launching.
e9c713a to
d97b02f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a simple example of one way to add support for testing on Sauce Labs. No need to actually merge this, it's just intended as an example.