Conversation
Summary of ChangesHello @praneethatchana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new file containing various code snippets for integrating and handling predictive back gestures using the NavigationEvent library within Jetpack Compose applications. These examples cover defining event handlers, registering them with dispatchers, managing their lifecycle, and dispatching custom navigation events, aligning with the Navigation Event Starting DAC Docs. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a new set of snippets for the androidx.navigationevent library, specifically for handling predictive back gestures. The snippets cover handler definition, registration, and custom input dispatching. I have identified a few areas for improvement, primarily focusing on Compose best practices (using remember) and consistency in thread safety annotations. These changes will ensure the snippets are both functional and follow recommended patterns for Android development.
| import androidx.navigationevent.NavigationEventHandler | ||
| import androidx.navigationevent.NavigationEventInfo | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.DisposableEffect |
There was a problem hiding this comment.
The remember function is required to ensure that the NavigationEventHandler instance persists across recompositions. Please add the corresponding import.
| import androidx.compose.runtime.DisposableEffect | |
| import androidx.compose.runtime.DisposableEffect | |
| import androidx.compose.runtime.remember |
| val myHandler = object: NavigationEventHandler<NavigationEventInfo>( | ||
| initialInfo = NavigationEventInfo.None, | ||
| isBackEnabled = true | ||
| ) { | ||
| override fun onBackStarted(event: NavigationEvent) { | ||
| // Prepare for the back event | ||
| } | ||
|
|
||
| override fun onBackProgressed(event: NavigationEvent) { | ||
| // Use event.progress for predictive animations | ||
| } | ||
|
|
||
| // This is the required method for final event handling | ||
| override fun onBackCompleted() { | ||
| // Complete the back event | ||
| } | ||
|
|
||
| override fun onBackCancelled() { | ||
| // Cancel the back event | ||
| } | ||
| } |
There was a problem hiding this comment.
In Jetpack Compose, objects created directly within a @Composable function are recreated on every recomposition. Wrapping the NavigationEventHandler in remember ensures that the same instance is reused, which is critical for maintaining internal state and preventing redundant registration/unregistration cycles when passed to effects like DisposableEffect.
val myHandler = remember {
object : NavigationEventHandler<NavigationEventInfo>(
initialInfo = NavigationEventInfo.None,
isBackEnabled = true
) {
override fun onBackStarted(event: NavigationEvent) {
// Prepare for the back event
}
override fun onBackProgressed(event: NavigationEvent) {
// Use event.progress for predictive animations
}
// This is the required method for final event handling
override fun onBackCompleted() {
// Complete the back event
}
override fun onBackCancelled() {
// Cancel the back event
}
}
}| public fun backCancelled() { | ||
| dispatchOnBackCancelled() | ||
| } |
There was a problem hiding this comment.
For consistency with the other event dispatch methods in this class (backStarted, backProgressed, and backCompleted), the backCancelled method should also be annotated with @MainThread.
@MainThread
public fun backCancelled() {
dispatchOnBackCancelled()
}
1 participant
NavEventSnippets as per the Navigation Event Starting DAC Docs