Skip to content

Comments

Fix CircularProgressIndicator size in snippets#799

Open
illuzor wants to merge 1 commit intoandroid:mainfrom
illuzor:fix-progress-indicator-size
Open

Fix CircularProgressIndicator size in snippets#799
illuzor wants to merge 1 commit intoandroid:mainfrom
illuzor:fix-progress-indicator-size

Conversation

@illuzor
Copy link

@illuzor illuzor commented Feb 15, 2026

width replaced with size, because using width causes the component to jitter during layout updates

Before
before

After
after

@illuzor illuzor requested a review from a team as a code owner February 15, 2026 13:38
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @illuzor, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI stability issue where CircularProgressIndicator components experienced jitter during layout updates. The fix involves switching from using Modifier.width to Modifier.size to correctly define the dimensions of these indicators, ensuring a smoother and more stable user experience.

Highlights

  • UI Stability Fix: Replaced Modifier.width with Modifier.size for CircularProgressIndicator components to prevent UI jitter during layout updates.
  • Modifier Usage Correction: Corrected the usage of size modifiers for CircularProgressIndicator in both determinate and indeterminate examples within the ProgressIndicator.kt snippet.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • compose/snippets/src/main/java/com/example/compose/snippets/components/ProgressIndicator.kt
    • Replaced the import for androidx.compose.foundation.layout.width with androidx.compose.foundation.layout.size.
    • Updated the CircularProgressIndicator in the CircularDeterminateIndicator composable to use Modifier.size(64.dp) instead of Modifier.width(64.dp).
    • Updated the CircularProgressIndicator in the IndeterminateCircularIndicator composable to use Modifier.size(64.dp) instead of Modifier.width(64.dp).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a layout jitter issue with CircularProgressIndicator in the provided snippets. By replacing Modifier.width() with Modifier.size(), the change ensures that the circular progress indicators have equal width and height, preventing distortion and layout instability during updates. The fix is appropriate and well-targeted. The code quality is good for example snippets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant