feat(tokenization): delete tokenization keys by name#117
Merged
Conversation
Update the Delete method in TokenizationKeyUseCase and TokenizationKeyRepository to accept a key name instead of a UUID. This change ensures that when a tokenization key is deleted by name, all its versions are correctly soft-deleted simultaneously. Key changes: - Changed Delete method signature to accept name string in both UseCase and Repository interfaces. - Updated MySQL and PostgreSQL repository implementations to soft-delete all versions by name. - Changed HTTP route from DELETE /v1/tokenization/keys/:id to DELETE /v1/tokenization/keys/:name. - Updated TokenizationKeyHandler.DeleteHandler to extract the name from the path. - Updated OpenAPI specification and docs/engines/tokenization.md to reflect the new API contract. - Updated unit tests for handler, use case, and both repository implementations. - Updated integration tests in tokenization_flow_test.go to verify name-based deletion. - Cleaned up unused uuid imports and variables introduced by the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Delete method in TokenizationKeyUseCase and TokenizationKeyRepository to accept a key name instead of a UUID. This change ensures that when a tokenization key is deleted by name, all its versions are correctly soft-deleted simultaneously.
Key changes: