feat(config): Make Metrics Server timeouts configurable#114
Merged
Conversation
…ields' as complete
Previously, the Metrics Server used hardcoded timeout values (15s for Read/Write, 60s for Idle). This change introduces environment variables to allow these timeouts to be configured, improving flexibility in different environments. Changes: - Added METRICS_SERVER_READ_TIMEOUT_SECONDS (default: 15s) - Added METRICS_SERVER_WRITE_TIMEOUT_SECONDS (default: 15s) - Added METRICS_SERVER_IDLE_TIMEOUT_SECONDS (default: 60s) - Implemented validation for timeouts (1s to 300s range) - Updated NewDefaultMetricsServer to accept custom timeout values - Integrated configuration into the Dependency Injection container - Updated .env.example with new configuration options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Metrics Server used hardcoded timeout values (15s for Read/Write,
60s for Idle). This change introduces environment variables to allow these
timeouts to be configured, improving flexibility in different environments.
Changes: