Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a new MDX documentation file that documents how to use KServe Modelcar (OCI container-based model storage) with the Alauda AI platform, including prerequisites, two packaging approaches, building and pushing OCI images, an InferenceService YAML example, verification, best practices, and troubleshooting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
docs/en/model_inference/inference_service/how_to/using_modelcar.mdx (1)
35-44: Clarify the YAML configuration path.The instruction says to add configuration "under
kserve.values", but the YAML snippet starts fromspec:. This may confuse users about exactly what to add and where. Consider either:
- Showing only the portion to add under
kserve.values, or- Clarifying that this is the complete path from the root of the AmlCluster values
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/en/model_inference/inference_service/how_to/using_modelcar.mdx` around lines 35 - 44, The YAML path is ambiguous; update the text to clarify where to place the snippet by either (a) replacing the current snippet with only the fragment to add under kserve.values (showing: kserve: storage: enableModelcar: true) and adjusting the surrounding sentence to say "add the following under kserve.values", or (b) explicitly state that the provided snippet is the full AmlCluster values path from root and keep the existing spec/components/kserve/values/kserve/... tree; reference kserve.values, spec, components, kserve, storage, and enableModelcar so readers know whether to paste the short fragment under kserve.values or the full spec tree at the AmlCluster root.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/en/model_inference/inference_service/how_to/using_modelcar.mdx`:
- Line 226: The sentence in the doc content currently reads "Using KServe
Modelcar (OCI container-based model storage) provides a efficient way to deploy
models..." — change "a efficient" to "an efficient" so it reads "provides an
efficient way to deploy models"; update the phrase in the same paragraph where
"Using KServe Modelcar (OCI container-based model storage)..." appears to fix
the grammar.
- Around line 54-67: The Dockerfile's COPY source path (COPY
Qwen2.5-0.5B-Instruct/ /models/) is inconsistent with the build instructions
that expect a generic models/ directory; update the Dockerfile to use the
generic source directory used by the build steps (e.g., change the COPY line to
copy from models/ into /models/) and adjust the accompanying comment to reflect
that it copies the local models/ folder contents so users following the build
instructions won't encounter a missing-source error.
- Line 167: Update the callout link target for "Extend Inference Runtimes":
locate the sentence containing `aml.cpaas.io/runtime-type: vllm` and change the
link target currently pointing to `./external_access_inference_service.mdx` to
`./custom_inference_runtime.mdx` so the "Extend Inference Runtimes" link
correctly points to the runtime extension documentation.
---
Nitpick comments:
In `@docs/en/model_inference/inference_service/how_to/using_modelcar.mdx`:
- Around line 35-44: The YAML path is ambiguous; update the text to clarify
where to place the snippet by either (a) replacing the current snippet with only
the fragment to add under kserve.values (showing: kserve: storage:
enableModelcar: true) and adjusting the surrounding sentence to say "add the
following under kserve.values", or (b) explicitly state that the provided
snippet is the full AmlCluster values path from root and keep the existing
spec/components/kserve/values/kserve/... tree; reference kserve.values, spec,
components, kserve, storage, and enableModelcar so readers know whether to paste
the short fragment under kserve.values or the full spec tree at the AmlCluster
root.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 513cbe3c-8655-448e-a7c2-0d2d9bc98d47
📒 Files selected for processing (1)
docs/en/model_inference/inference_service/how_to/using_modelcar.mdx
docs/en/model_inference/inference_service/how_to/using_modelcar.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| ## Conclusion | ||
|
|
||
| Using KServe Modelcar (OCI container-based model storage) provides a efficient way to deploy models in Alauda AI platform. By following the steps outlined in this guide, you can package your models as OCI images and deploy them with faster startup times and improved resource utilization. No newline at end of file |
There was a problem hiding this comment.
Minor grammar fix needed.
"a efficient" should be "an efficient".
📝 Suggested fix
-Using KServe Modelcar (OCI container-based model storage) provides a efficient way to deploy models in Alauda AI platform. By following the steps outlined in this guide, you can package your models as OCI images and deploy them with faster startup times and improved resource utilization.
+Using KServe Modelcar (OCI container-based model storage) provides an efficient way to deploy models in Alauda AI platform. By following the steps outlined in this guide, you can package your models as OCI images and deploy them with faster startup times and improved resource utilization.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Using KServe Modelcar (OCI container-based model storage) provides a efficient way to deploy models in Alauda AI platform. By following the steps outlined in this guide, you can package your models as OCI images and deploy them with faster startup times and improved resource utilization. | |
| Using KServe Modelcar (OCI container-based model storage) provides an efficient way to deploy models in Alauda AI platform. By following the steps outlined in this guide, you can package your models as OCI images and deploy them with faster startup times and improved resource utilization. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/en/model_inference/inference_service/how_to/using_modelcar.mdx` at line
226, The sentence in the doc content currently reads "Using KServe Modelcar (OCI
container-based model storage) provides a efficient way to deploy models..." —
change "a efficient" to "an efficient" so it reads "provides an efficient way to
deploy models"; update the phrase in the same paragraph where "Using KServe
Modelcar (OCI container-based model storage)..." appears to fix the grammar.
Deploying alauda-ai with
|
| Latest commit: |
ec76a99
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6dd1e45.alauda-ai.pages.dev |
| Branch Preview URL: | https://add-modelcar.alauda-ai.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit