Improve bundle version handling #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing bundle tag's, make them VersionInfo objects to better handle sorting. It is necessary to relax the parsing rules to do this. This also removes leading 'v' characters, to support the common version scheme of 'v1.0.0'.
If a tag cannot be parsed, and is therefore not a valid version tag, don't try to sort the tags. When adding a new tag that is invalid, add it as the latest tag. When loading tags from disk, use the list as is.
Since this is used throughout Bundle, pull it out into its own function.
FoamyGuy
approved these changes
Dec 5, 2025
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
This looks good to me, tested successfully. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing bundle tag's, make them
VersionInfoobjects to better handle sorting. It is necessary to relax the parsing rules to do this. This also removes leadingvcharacters, to support the common version scheme ofv1.0.0.