Conversation
Drag0nSlay
force-pushed
the
add-docker-tests
branch
from
8bd4138 to
898dfc1
Compare
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
These files are required to support the existing GitHub OSV tests when running the test suite inside the Docker-based CI.
When tests are executed in the Debian-based python:3.9 image (used in production), the GitHub OSV importer returns an additional valid test case that was not previously covered in the existing fixtures. This causes the OSV test to fail inside Docker, even though it passes on ubuntu-latest.
There was a problem hiding this comment.
@Drag0nSlay we already have these test files https://github.com/aboutcode-org/vulnerablecode/tree/96a52e82a8beb433e9701a1275aa5a28bc16221e/vulnerabilities/tests/test_data/github_osv
Your main branch is 2 months old please pull the latest change and rebase your PR.
There was a problem hiding this comment.
Okay, Branch Updated. Thanks
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
No production code is modified; this change only extends test coverage to ensure consistent behavior across environments.
There was a problem hiding this comment.
No production code is modified; this change only extends test coverage to ensure consistent behavior across environments.
This is vague response, please do not waste the time of maintainers with copy pasted LLM response and code.
Signed-off-by: Drag0nSlay <ak5518786@gmail.com>
Drag0nSlay
force-pushed
the
add-docker-tests
branch
from
898dfc1 to
9277049
Compare
2 participants
Summary
This PR adds a Docker-based GitHub Actions workflow to run the test
suite inside the same Debian-based Python image used in production.
This helps catch environment-specific issues that differ from
ubuntu-latest CI runs.
Fixes #517