Migrate Suse Scores importer to advisory V2#2101
Open
ziadhany wants to merge 5 commits intoaboutcode-org:mainfrom
Open
Migrate Suse Scores importer to advisory V2#2101ziadhany wants to merge 5 commits intoaboutcode-org:mainfrom
ziadhany wants to merge 5 commits intoaboutcode-org:mainfrom
Conversation
Collaborator
Author
|
ziadhany
commented
Jan 2, 2026
| aliases=[], | ||
| summary="", | ||
| severities=severities, | ||
| references_v2=[ReferenceV2(reference_id=cve_id, url=self.url)], |
Collaborator
Author
There was a problem hiding this comment.
@TG1999 We can’t create an advisory without a summary, affected_packages, or references, so we should at least include a reference.
Contributor
There was a problem hiding this comment.
@ziadhany we should change this logic then, severities are also a good data point to capture, so if an advisory have a severity we should be able to create it.
Collaborator
Author
There was a problem hiding this comment.
Okay, I will create an issue for that.
ziadhany
commented
Jan 6, 2026
|
|
||
| elif isinstance(advisory_data, AdvisoryData): | ||
| if advisory_data.references_v2: | ||
| if advisory_data.references_v2 or advisory_data.severities or advisory_data.patches: |
Collaborator
Author
There was a problem hiding this comment.
@TG1999 @keshav-space The problem in this issue
- Update Advisory Logic to Allow Creation with Only CVE ID and Severity #2105
is in thecompute_content_idfunction. We are missing advisory_id and patches, and we also lack a check for severities or patches, which is required to compute the hash correctly I think.
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
… advisory when it has severities, patches, references_v2, and an advisory_id Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
264aef0 to
c5c3b04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: