Fix incorrect exception handling in insert_advisory_v2#2084
Open
Adityakk9031 wants to merge 2 commits intoaboutcode-org:mainfrom
Open
Fix incorrect exception handling in insert_advisory_v2#2084Adityakk9031 wants to merge 2 commits intoaboutcode-org:mainfrom
Adityakk9031 wants to merge 2 commits intoaboutcode-org:mainfrom
Conversation
Adityakk9031
force-pushed
the
fix/insert-advisory-v2-multipleobjectsreturned
branch
from
1b0b259 to
afe9b28
Compare
Contributor
Author
|
@ziadhany please merge the pr |
Collaborator
|
@Adityakk9031 It would be great if you could add a simple test for it. |
Signed-off-by: Aditya kumar singh <143548997+Adityakk9031@users.noreply.github.com>
Signed-off-by: Aditya kumar singh <143548997+Adityakk9031@users.noreply.github.com>
Adityakk9031
force-pushed
the
fix/insert-advisory-v2-multipleobjectsreturned
branch
from
5ebf8fa to
97b2b39
Compare
Contributor
Author
|
@ziadhany check it is ok or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
insert_advisory_v2 uses AdvisoryV2.objects.get_or_create(...), but the except block incorrectly catches Advisory.MultipleObjectsReturned.
When duplicate AdvisoryV2 records exist, Django raises AdvisoryV2.MultipleObjectsReturned, which was not being caught, causing the exception to propagate and break the pipeline.
Solution
Updated the exception handling to catch the correct exception:
Replaced Advisory.MultipleObjectsReturned
With AdvisoryV2.MultipleObjectsReturned
This ensures duplicate AdvisoryV2 records are handled correctly and prevents unexpected crashes during advisory ingestion.
Related Issue
Fixes: Incorrect try except in insert_advisory_v2 #2081
#2081