feat: add streaming tool use (rebased #1884 on latest main)#2129
Open
XyLearningProgramming wants to merge 5 commits intoabetlen:mainfrom
Open
feat: add streaming tool use (rebased #1884 on latest main)#2129XyLearningProgramming wants to merge 5 commits intoabetlen:mainfrom
XyLearningProgramming wants to merge 5 commits intoabetlen:mainfrom
Conversation
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Summary
Rebased @lsorber's PR #1884 onto the latest upstream
main(v0.3.16) and resolved merge conflicts.All original commits preserved:
a08a754feat: add streaming tool usef1da6e9fix: remove strict=True to support Python 3.9e9fa51efeat: improve tool use robustnessa41d866test: skip if insufficient resources on macOS72b0b51fix: apply missing _convert_text_completion_logprobs_to_chatConflicts resolved
Qwen25VLChatHandler-relatedimport llama_cpp.llama_cpp as llama_cppalongside the PR's modernized imports.Qwen25VLChatHandlerclass (added after feat: add streaming tool use #1884's base) and placed the new helper functions (_accumulate_chunks,_convert_chunks_to_completion,_stream_tool_calls) after it.Closes #1883. Related: #1869, #1756, #1503.
Credit: all implementation by @lsorber in #1884.