fix: Update invocation metadata from grpc.aio.ServicerContext to use the correct syntax

[jubonni]

Description

invocation_metadata from grpc.aio.ServicerContext was treated as a property instead of a method which prevented extracting the invocation metadata

• Follow the CONTRIBUTING Guide.
• Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Important Prefixes for release-please:
    • fix: which represents bug fixes, and correlates to a SemVer patch.
    • feat: represents a new feature, and correlates to a SemVer minor.
    • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
• Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
• Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

[gemini-code-assist]

Summary of Changes

Hello @jubonni, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the gRPC server's request handling where invocation metadata was not being correctly retrieved. By adjusting how invocation_metadata is accessed on the ServicerContext, the system can now properly extract and utilize this essential information, ensuring correct processing of gRPC requests that rely on metadata.

Highlights

• gRPC Metadata Extraction Fix: Corrected the usage of context.invocation_metadata from grpc.aio.ServicerContext by calling it as a method (invocation_metadata()) instead of accessing it as a property. This resolves a bug preventing proper metadata extraction.
• Code Simplification: Removed an unnecessary elif block in _get_metadata_value that handled Sequence types, as invocation_metadata() consistently returns a grpc.aio.Metadata object.
• Test Updates: Modified existing test cases to correctly mock the invocation_metadata method using mock_grpc_context.invocation_metadata.return_value to align with the behavioral change.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where invocation_metadata was accessed as a property instead of a method on grpc.aio.ServicerContext. The changes in the application code and the corresponding test mocks are accurate and address the issue effectively. I've added one minor suggestion to make the code in _get_metadata_value more concise. Overall, this is a good fix.

[ishymko]

Thank you @jubonni!

Added one clarification question.

[ishymko]

Are you sure this needs to be removed?

From the docs invocation_metadata() can return Sequence, looks like this check was for this exactly.