Work in progress: Improve filestream#173
Open
pbricout wants to merge 20 commits intoZazama:filestreamfrom
Open
Work in progress: Improve filestream#173pbricout wants to merge 20 commits intoZazama:filestreamfrom
pbricout wants to merge 20 commits intoZazama:filestreamfrom
Conversation
- simplify the code and remove some functions - remove unnecessary unlink before the rename this is acually better as rename is atomic so we don't lose the original file if the rename fails - delete the temp file in the case of error - factor common code for tmp filename: this allows to replace two functions with one - factor common code in file copy (findId3TagPosition): this simplifies the function - factor common code to remove id3 tag from buffer: this allows to replace two functions with one - simplify function names - split long lines - implementation is much shorter - the sync/async implementations almost only differs with this calls to sync/async APIs
- remove support for function which do not make sense for: create, read, write, update, promises - clean up return types and throws in case of error (create with callback for example)
- introduce WriteOptions type - implements a new write API proposal - update tests to use file buffer size options (more tests to do to improve coverage)
Returning this information is cheap and will simplify code in other places.
- also simplify some names
Not really simpler, the only benefit is more scoped `let tag`. Not really worth the extra complexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New implementation makes completely isomorphic the read/write sync and async implementation, the only difference in the async implementation are the file calls and the await.
The new implementation handles multiple ID3 tags.
Still to do: