Skip to content

fix: 온보딩 디자인 QA 반영 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seoyoon513 merged 5 commits into from
Feb 26, 2026
Merged

fix: 온보딩 디자인 QA 반영 #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32acd3c
[BOOK-510] chore: 온보딩 세 번째 이미지 리소스 교체
seoyoon513 Feb 20, 2026
7a862d8
[BOOK-510] fix: 온보딩 하이라이트 문구 설정
seoyoon513 Feb 20, 2026
1fcb1ad
[BOOK-510] fix: 온보딩 이미지 잘리는 문제 수정
seoyoon513 Feb 20, 2026
0167087
[BOOK-510] fix: 온보딩 버튼 문구 수정
seoyoon513 Feb 20, 2026
f616688
[BOOK-510] chore: code style check success
seoyoon513 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion feature/onboarding/src/main/kotlin/com/ninecraft/booket/feature/onboarding/OnboardingUi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ internal fun OnboardingUi(
OnboardingPage(
imageRes = R.drawable.img_onboarding_third,
titleRes = R.string.onboarding_third_page_title,
highlightTextRes = R.string.onboarding_third_highlight_text,
descriptionRes = R.string.onboarding_third_page_description,
)
}
Expand All @@ -85,7 +86,7 @@ internal fun OnboardingUi(
onClick = {
state.eventSink(OnboardingUiEvent.OnNextButtonClick(state.pagerState.currentPage))
},
text = stringResource(R.string.next),
text = stringResource(R.string.start),
sizeStyle = largeButtonStyle,
colorStyle = ReedButtonColorStyle.PRIMARY,
modifier = Modifier
Expand Down
5 changes: 1 addition & 4 deletions ...rding/src/main/kotlin/com/ninecraft/booket/feature/onboarding/component/OnboardingPage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.AnnotatedString
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp
import com.ninecraft.booket.core.common.utils.HighlightedText
import com.ninecraft.booket.core.designsystem.ComponentPreview
import com.ninecraft.booket.core.designsystem.theme.Black
Expand Down Expand Up @@ -50,9 +49,7 @@ internal fun OnboardingPage(
painter = painterResource(imageRes),
contentDescription = "Onboarding Graphic",
contentScale = ContentScale.FillWidth,
modifier = Modifier
.fillMaxWidth()
.height(274.dp),
modifier = Modifier.fillMaxWidth(),
)
Spacer(modifier = Modifier.height(ReedTheme.spacing.spacing8))
Text(
Expand Down
Binary file modified feature/onboarding/src/main/res/drawable/img_onboarding_third.webp
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion feature/onboarding/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="next">다음</string>
<string name="start">시작하기</string>
<string name="onboarding_first_page_title">읽고 있는 책을 등록하고\n바로 기록해보세요</string>
<string name="onboarding_first_page_description">책을 덮기 전, 마음에 남은 문장과\n감정을 간편하게 남길 수 있어요</string>
<string name="onboarding_second_page_title">독서 중 느낀 감정을\n자세히 남겨 보세요</string>
Expand All @@ -9,4 +9,5 @@
<string name="onboarding_third_page_description">감정 캐릭터와 함께\n이미지로 저장하고 공유할 수 있어요</string>
<string name="onboarding_first_highlight_text">기록</string>
<string name="onboarding_second_highlight_text">감정</string>
<string name="onboarding_third_highlight_text">공유</string>
</resources>
Loading