Open
Conversation
A stack size of 128 is insufficient in the worst-case scenario Signed-off-by: Damian Ho <damian_ho_xu_yang@yahoo.com>
zx2c4-bot
force-pushed
the
master
branch
14 times, most recently
from
ed89fed to
8f4414d
Compare
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
e8db181 to
ea6b8e7
Compare
zx2c4-bot
force-pushed
the
master
branch
3 times, most recently
from
7cd1d2e to
ffb8cd6
Compare
zx2c4-bot
force-pushed
the
master
branch
3 times, most recently
from
4626f5e to
f9d9b4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stack size of 128 is insufficient in the worst-case scenario and leads to a system freeze upon stopping / using syncconf
root_free_rcu / root_remove_peer_lists:
We can have up to 128 "0" branches and 1 "1" branch pushed into the stack at once, for a total of 129 elements
walk_remove_by_peer:
With 129 possible CIDR values, we can have up to 129 elements in the stack at once
Such configurations are (very) unlikely to occur as it would require rather specific peer allowedips
However, it would still be good to guard against such scenarios as they are technically possible (I have managed to trigger said scenarios)
Signed-off-by: Damian Ho damian_ho_xu_yang@yahoo.com