feat(IdeasSummary): Show student responses #2268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 4 blocking issues (4 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| { text: 'Computer response 2', ideas: [{ detected: true, name: 'idea2' }] } | ||
| ] | ||
| } | ||
| }) |
| { text: 'Computer response 1b', ideas: [{ detected: true, name: 'idea1' }] } | ||
| ] | ||
| } | ||
| }) |
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
hirokiterashima
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Please style as you see fit. It would be great to distinguish between the responses a bit more, with maybe a border or background. Maybe make the responses italic?
Also, as you can see in the image below, the expanded idea has 3 students who had this idea, but we only show 2 users. Would this be a bit confusing because users might expect to see 3 students? Maybe we should explain this in the UI, like displaying a message "showing 2 of 3 responses" or "sample responses" in the expanded panel, or "click to see sample responses" when hovering over the expand icon?
Changes
Test