Fix SteamVR_Settings being overwritten during asset import#974
Open
Peaj wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fix SteamVR_Settings being overwritten during asset import#974Peaj wants to merge 1 commit intoValveSoftware:masterfrom
Peaj wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
As Resource.Load fails and returns null during asset import SteamVR_Settings.instance cannot be called from DidReloadScripts Fixes ValveSoftware#949
Collaborator
|
Despite this taking over a year to get in, we appreciate the PR. This fix will be in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SteamVR_Settings are currently overwritten on each asset (re)import as mentioned in #949.
Calling Resources.Load during asset import always returns null.
SteamVR_Settings.instance is using Resources.Load to load existing settings.
SteamVR_CopyExampleInputFiles is calling SteamVR_Settings.instance from DidReloadScripts callback which is first called during asset import and returns null.
This leads to the SteamVR_Settings asset getting overwritten every time the project is (re)imported as mentioned in #949.
This PR is delaying the call to SteamVR_Settings.instance in SteamVR_CopyExampleInputFiles that happens directly during DidReloadScripts till the editor update loop where it is safe to execute Resources.Load.
Fixes #949