Validate tech_name param in compiler/globals.py#210
Open
htm23x wants to merge 6 commits intoVLSIDA:stablefrom
Open
Validate tech_name param in compiler/globals.py#210htm23x wants to merge 6 commits intoVLSIDA:stablefrom
htm23x wants to merge 6 commits intoVLSIDA:stablefrom
Conversation
We need to pre-validate the tech_name param in the config file or python will comply with a non-very-descriptive message that can confuse the user about where's the problem.
Forgot to add the freepdk45 tech_name in validation
Ooops, I forgot to add the freepdk45 mention in the debug.log string
mguthaus
reviewed
Oct 26, 2023
Collaborator
mguthaus
left a comment
mguthaus
left a comment
There was a problem hiding this comment.
People can have a technology that doesn't come with OpenRAM. The only way to check is if there is a directory of the given name in the colon separated OPENRAM_TECH paths.
Fixed incorrect tech_name "scn3m_subm" (correct is "scn3me_subm", note the 3mE).
Author
|
Oh, very true... let me check if I can modify the code to validate it in that way. |
We're now validating the tech_name param specified by the user in the config file listing all the subfolders present in the technology folder. If the technology specified is not present as folder, we will emit an error and quit.
Some tabs/extra spaces were inserted accidentally by GitHub text editor in the tech_name param validation, so has to remove them.
Author
|
Ok, got it! I changed the code to iterate over all the technology subfolders. If the user tries to specify a technology name not present there, an error will be emit and the execution quits. Please, take a look to my changes in the compiler/globals.py and try to merge it (I tested it, works ok apparently). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pre-validate the tech_name param in the config file or python will comply with a non-very-descriptive message that can confuse the user about where's the problem.