Draft
Conversation
Collaborator
Author
|
Integration requires more effort see #606 -- don't have time to work on this atm. |
Route Astropy WCS projections through a native AstroAxes bridge instead of the external container, preserve per-axes transform dispatch for SubplotGrid, and keep shared panel labels stable for both cartesian and astro axes.
Move logical ticklabel state access into the axes classes so Figure can share and hand off panel labels without branching on cartesian, geo, and astro subplot types.
Make the Astropy WCS bridge a true optional import by loading and registering AstroAxes only on WCS-specific access, while keeping the panel/share refactors and import behavior covered by tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #606
Issue #606 is that UltraPlot does not correctly handle Astropy WCS projection objects passed as
projection=mosaic.wcs.In practice, this shows up when code like
ax.get_transform("icrs")fails with:The underlying problem is:
masked by the base Matplotlib artist API.