Skip to content

Fix backward hooks Runtime Error #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evcyen wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix backward hooks Runtime Error #1175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions transformer_lens/hook_points.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,12 @@ def full_hook(
module_input: Any,
module_output: Any,
):
if (
dir == "bwd"
): # For a backwards hook, module_output is a tuple of (grad,) - I don't know why.
module_output = module_output[0]
return hook(module_output, hook=self)
# For a backwards hook, module_output is a tuple of (grad,)
hook_arg = module_output[0] if dir == "bwd" else module_output
result = hook(hook_arg, hook=self)
if dir == "bwd" and result is not None:
return result if isinstance(result, tuple) and len(result) == 1 else (result,)
return result

# annotate the `full_hook` with the string representation of the `hook` function
if isinstance(hook, partial):
Expand Down