Conversation
  DeepSource reviewed changes in the commit range For detailed review results, please see the PR on DeepSource ↗ PR Report Card
Code Review Summary
How are these analyzer statuses calculated?Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings. |
|
|
😭 |
这一部分代码我想提出一点修改建议:
1.密码哈希我想你应该做成全局变量,这样可以提高一些效率。毕竟每一个请求都要哈希一次有点浪费资源了。
2.请求登录nv1可以只登录一次后保存重复使用，当然也要做好失效的检测。这样做对于nv1和玩家是友好的。
|
|
还有，requests本身带有.json()方法转化成json。如果你想统一处理可以把请求单独封装成一个函数，让他做处理 |
| name = "辅助用户循环签到" | ||
| author = "丸山彩" | ||
| version = (0, 0, 1) | ||
|
|
There was a problem hiding this comment.
| url = "https://nv1.nethard.pro/api/" | |
辅助用户循环签到/__init__.py
Outdated
|
|
||
| login_url = "https://nv1.nethard.pro/api/user/login" | ||
| sign_url = "https://nv1.nethard.pro/api/helper-bot/daily-sign" | ||
|
|
There was a problem hiding this comment.
| login_url = "https://nv1.nethard.pro/api/user/login" | |
| sign_url = "https://nv1.nethard.pro/api/helper-bot/daily-sign" |
辅助用户循环签到/__init__.py
Outdated
| Print.print_err(f"[{self.name}] 登录失败：{msg}") | ||
| return | ||
|
|
||
| r2 = sess.get(sign_url, headers=headers, timeout=timeout_f) |
There was a problem hiding this comment.
| r2 = sess.get(sign_url, headers=headers, timeout=timeout_f) | |
| r2 = sess.get(f"{self.url}helper-bot/daily-sign", headers=headers, timeout=timeout_f) |
There was a problem hiding this comment.
f"{self.url}helper-bot/daily-sign" or f"{self.url}/helper-bot/daily-sign"?
There was a problem hiding this comment.
f"{self.url}helper-bot/daily-sign"orf"{self.url}/helper-bot/daily-sign"?
我前面url有后面的/了,所有只能用f"{self.url}helper-bot/daily-sign"
3 participants
NV1 辅助用户循环签到，用于给机器人涨经验值