Skip to content

fix(simple camera): listen resize change on container element instead of window #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kurtil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(simple camera): listen resize change on container element instead of window #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions packages/core/src/core/Worlds/src/simple-camera.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ export class SimpleCamera extends BaseCamera implements Updateable, Disposable {
*/
three: THREE.PerspectiveCamera | THREE.OrthographicCamera;

protected _resizeObserver: ResizeObserver | null = null;

private _allControls = new Map<string, CameraControls>();

/**
Expand Down Expand Up @@ -92,10 +94,9 @@ export class SimpleCamera extends BaseCamera implements Updateable, Disposable {
super(components);
this.three = this.setupCamera();

this.setupEvents(true);

this.worlds.onItemSet.add(({ value: world }) => {
const controls = this.newCameraControls();
this.setupEvents(true);
this._allControls.set(world.uuid, controls);
});

Expand All @@ -105,6 +106,7 @@ export class SimpleCamera extends BaseCamera implements Updateable, Disposable {
controls.dispose();
this._allControls.delete(world.uuid);
}
this._resizeObserver?.disconnect();
});

// this.onWorldChanged.add(({ action, world }) => {
Expand Down Expand Up @@ -225,10 +227,22 @@ export class SimpleCamera extends BaseCamera implements Updateable, Disposable {
}

private setupEvents(active: boolean) {
if (this._resizeObserver) {
this._resizeObserver.disconnect();
this._resizeObserver = null;
}

if (active) {
window.addEventListener("resize", this.updateAspect);
} else {
window.removeEventListener("resize", this.updateAspect);
if (!this.currentWorld) {
throw new Error("This camera needs a world to work!");
}
if (!this.currentWorld.renderer) {
throw new Error("This camera needs a renderer to work!");
}

const { domElement } = this.currentWorld.renderer.three;
this._resizeObserver = new ResizeObserver(this.updateAspect);
this._resizeObserver.observe(domElement);
}
}

Expand Down