Open
Conversation
gkubisa
requested changes
May 6, 2021
gkubisa
left a comment
gkubisa
left a comment
There was a problem hiding this comment.
Sorry it took me so long to review it. Would you mind making some improvements before I merge this PR?
| @@ -0,0 +1,16 @@ | |||
| import { Duplex } from "stream"; | |||
| import WebSocket from 'ws'; | |||
There was a problem hiding this comment.
@types/ws would need to be added as a dependency to package.json.
| declare class WebSocketJSONStream extends Duplex { | ||
| private _emittedClose; | ||
| private ws; | ||
| constructor(ws: WebSocket); |
There was a problem hiding this comment.
WebSocketJSONStream works with a browser version of WebSocket too, so that should be taken into the account.
There was a problem hiding this comment.
Do you have any ideas on how to address it? I think /// <reference lib="dom" /> should provide WebSocket... Would we then still need import WebSocket from 'ws';?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #5
Add The Typescript definitions. @gkubisa