Try to make lupin working with threads#4333
Open
samuelgarcia wants to merge 22 commits intoSpikeInterface:mainfrom
Open
Try to make lupin working with threads#4333samuelgarcia wants to merge 22 commits intoSpikeInterface:mainfrom
samuelgarcia wants to merge 22 commits intoSpikeInterface:mainfrom
Conversation
…thread_an_no_nogil
for more information, see https://pre-commit.ci
This was referenced Jan 19, 2026
alejoe91
reviewed
Jan 21, 2026
Collaborator
|
I have a problem with the branch @samuelgarcia , this is crashing for your dev notebooks with the compute_analyzer() case... |
…erface into thread_an_no_nogil
alejoe91
reviewed
Feb 5, 2026
Comment on lines
434
to
438
| if preferred_mp_context is not None and preferred_mp_context != mp_context: | ||
| warnings.warn( | ||
| f"You processing chain using pool_engine='process' and mp_context='{mp_context}' is not possible." | ||
| f"So use mp_context='{preferred_mp_context}' instead") | ||
| mp_context = preferred_mp_context |
Member
There was a problem hiding this comment.
What if a preprocessor wants to use spawn on linux (maybe because it uses GPUs)?
Member
Author
There was a problem hiding this comment.
Then this is handle because mp_context = preferred_mp_context
This is the same logic as before ?
Collaborator
|
@sam you should merge my optimizations for the waveforms/templates estimations. And do not forget your patch for shallow_copies. |
yger
reviewed
Feb 5, 2026
yger
reviewed
Feb 5, 2026
This is useless and buggy
Member
Author
|
Ready on my side |
for more information, see https://pre-commit.ci
yger
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This try to make lupin working with thread.
This will be usefull because on windows the spwan and process parrallel is using too much memory
this replace:
#4331
#4309