Open
Conversation
Member
|
Clearly I totaly I lost the control here. |
Member
Author
|
Haha, I don't think so Sam! The core logic has changed much - most of the gross code is related to storing the chain of curations and being able to save them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to apply the current curation to the analyzer, creating a new analyzer in memory.
What this PR does:
apply_curationbutton, we create a new, curated analyzer in memory. All views are_reinitialized and theCurationModelis created and stored incontroller.applied_curationsand the current curation is cleared. Now the user can start curating again._reinitializemethod to all Views, allowing the view to update when the analyzer is updated (might also be useful for re-computations!)SequentialCuration.I think this is pretty much done!
To do: