Draft
Conversation
…fy implementation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to batch update nodes.
A couple things to note:
UpdateNodes(nodes []*Node) errorsignature for the Batch interface because this allows me to use two different implementations for updating depending on the number of nodes being updated. If the update is below a certain threshold,LargeNodeUpdateThreshold(currently set to 1M nodes), we do the typical batched SQLUPDATE...SET.... Above that threshold, we instead do aCOPY...FROM...into a temporary table for the transaction, and thenMERGE INTOthe nodes table. This seems to be marginally faster for 1M+ updates, and should have even better scalability for much larger updates.BatchOptionparameter to theBatchOperationfunction signature that allows one to set aBatchWriteSizefor theBatchOperationops.go:func UpdateNodes(ctx context.Context, graphDB graph.Database, nodes []*graph.Node, batchSize ...int) errorthat I think should be the first tool users of DAWGS reach for when updating nodes(s *Node) StripAllPropertiesExcept(except ...string). The reason for this is if a developer is working with fully hydrated nodes in memory, but they only change one property and want to update all these nodes, we can cut down on a lot of network traffic to DB by removing all but the properties we care about before sending the nodes to the DB to be updated. The DB also does not need to bother parsing unnecessary information as well.TODO: Add neo4j implementation