provide newIndex value in onDrop event#2429
Open
kennyrkun wants to merge 1 commit intoSortableJS:masterfrom
Open
provide newIndex value in onDrop event#2429kennyrkun wants to merge 1 commit intoSortableJS:masterfrom
kennyrkun wants to merge 1 commit intoSortableJS:masterfrom
Conversation
Previously, null was provided for this event. This made it difficult to detect whether an item was moved, or simply picked up and put down without moving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This is a really simple patch that solves a small problem I was having with the library.
I check
if (event.oldIndex == event.newIndex && event.to == event.from)to determine if the item was actually moved, or just picked up and put down. The event always provided null fornewIndex, so it was impossible to tell. Using thenewIndexvariable provided just above where the event is fired allowed me use this logic.Previously, null was always provided for this event. I do not know why, or if it was necessary, but in my use case this fixed the problem and I haven't noticed any other issues. The usage guide in the readme says that this value should include the
newIndexof the item, so I think that always providing null was unintended.