PLUGINAPI-178 Move the plugin manifest tooling to the sonar-plugin-api repo#274
Merged
PLUGINAPI-178 Move the plugin manifest tooling to the sonar-plugin-api repo#274
Conversation
Member
Author
|
@damien-urruty-sonarsource this should help removing duplication between products. Feel free to review if you have time. |
5f553ad to
adc1826
Compare
…i repo This make sense because the Manifest is part of the plugin contract, even if is not directly part of the Java API. Many components are duplicating this code (Scanners, SonarLint, SQS/SQC, Update Center, Maven Packaging plugin...)
adc1826 to
61d591a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This make sense because the Manifest is part of the plugin contract, even if is not directly part of the Java API. Many components are duplicating this code (Scanners, SonarLint, SQS/SQC, Update Center, Maven Packaging plugin...)
For SonarSourcers:
Check before making the PR ready for review
@since X.Yin the JavaDoc@Deprecated@deprecated since X.Yin the JavaDocsnake_case, for example:test_validate_input. It can also start with themethodNameFor external contributors:
Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".
With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:
Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
Use the following formatting style: SonarSource/sonar-developer-toolset
Provide a unit test for any code you changed
If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (PLUGINAPI-XXXX)
Please note that opening the PR will notify all the squad members. Please make sure you keep it in DRAFT and mark it ready, when all the checks are green.
We will try to give you feedback on your contribution as quickly as possible.
Thank You! The SonarSource Team