Stabilise damage source experiment#8414
Open
tibisabau wants to merge 4 commits intoSkriptLang:dev/featurefrom
Open
Stabilise damage source experiment#8414tibisabau wants to merge 4 commits intoSkriptLang:dev/featurefrom
tibisabau wants to merge 4 commits intoSkriptLang:dev/featurefrom
Conversation
tibisabau
requested review from
APickledWalrus and
Pesekjak
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
Efnilite
approved these changes
Jan 28, 2026
Member
|
This shopuld be pushing it to MAINSTREAM, not STABLE |
Member
|
Should remove the experiment from the damage source tests too. |
sovdeeth
added
the
enhancement
Pesekjak
reviewed
Jan 30, 2026
Contributor
Pesekjak
left a comment
Pesekjak
left a comment
There was a problem hiding this comment.
remove the UnstableApiUsage supression if everything in the affected classes is now stabilized api
Pesekjak
approved these changes
Jan 30, 2026
skriptlang-automation
bot
added
feature-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Damage sources were marked as experimental because they relied on unstable Bukkit APIs. The relevant Bukkit APIs have been stable since Minecraft 1.21.7 with no reported breaking changes, making the experimental status unnecessary.
Solution
Stabilized the damage source feature by removing experimental restrictions:
DAMAGE_SOURCElifecycle fromLifeCycle.EXPERIMENTALtoLifeCycle.STABLEinFeature.javaimplements DamageSourceExperimentSyntaxfrom all 9 damage source syntax element classesDamageSourceExperimentSyntax.javainterface file as it's no longer neededTesting Completed
./gradlew clean build- Successful with 0 errors./gradlew clean quickTest- All tests passed, including:Supporting Information
This is not a breaking change. Existing scripts using
using damage sourcewill continue to work. Users can now use damage source syntax without the experimental declaration.Completes: #8333
Related: none
AI assistance: GitHub Copilot with Claude Sonnet 4.5 model
The code in this pull request was generated by GitHub Copilot with the Claude Sonnet 4.5 model.