Add ts cart transform#276
Open
lhoffbeck wants to merge 3 commits intorename-cart-transform-examplefrom
Open
Conversation
lhoffbeck
commented
Jul 5, 2023
Contributor
Author
There was a problem hiding this comment.
@nickwesselman is it good practice to add tests here or can we ✂️ ?
lhoffbeck
commented
Jul 5, 2023
sample-apps/bundles-cart-transform/extensions/cart-expand-ts/src/index.ts
Outdated
Show resolved
Hide resolved
lhoffbeck
commented
Jul 5, 2023
sample-apps/bundles-cart-transform/extensions/cart-expand-ts/generated/api.ts
Outdated
Show resolved
Hide resolved
lhoffbeck
commented
Jul 5, 2023
sample-apps/bundles-cart-transform/extensions/cart-expand-ts/input.graphql
Outdated
Show resolved
Hide resolved
Contributor
|
I will say that in general, we've been avoiding TS examples and sticking to JS and Rust in order to cut down on maintenance. JS is close enough to provide TS developers what they need. |
sample-apps/bundles-cart-transform/extensions/cart-expand-ts/generated/api.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a basic example for CartTransfrom written in TS.
1 -
bundles. component_references-> List.productVariant metafield referencing bundle components2 -
bundles. component_quantities-> List.Integer metafield with component quantitiesDemo video
Demo product -> black variant (PW
gaicru)