Upgrade to AsmResolver 6 beta 6#521
Merged
SamboyCoding merged 2 commits intoSamboyCoding:developmentfrom Feb 28, 2026
Merged
Conversation
SamboyCoding
requested changes
Feb 28, 2026
| } | ||
|
|
||
| return baseType.MakeGenericInstanceType(typeArguments); | ||
| var runtimeContext = Cpp2IlApi.CurrentAppContext!.GetExtraData<RuntimeContext>("RuntimeContext") ?? throw new("AsmResolver runtime context not found in application analysis context"); |
Owner
There was a problem hiding this comment.
Not massively in love with this adding a new reliance on the static state (CurrentAppContext) I'm somewhat trying to remove.
Contributor
Author
There was a problem hiding this comment.
It's not really new. This method already relied on Cpp2IlApi.CurrentAppContext transitively through TryLookupTypeDefKnownNotGeneric.
SamboyCoding
approved these changes
Feb 28, 2026
ds5678
force-pushed
the
asmresolver-6-beta-6
branch
from
1dc7ba9 to
23c07e7
Compare
Pull Request Test Coverage Report for Build 22528287954Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.