Conversation
emlynjdavies
requested changes
Mar 10, 2026
Collaborator
emlynjdavies
left a comment
emlynjdavies
left a comment
There was a problem hiding this comment.
Can you write. adescription of this PR, and explain why we need to expand cf_metadata.json?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #366, where the correct pixel dimensions of the image was not passed to nc_vc_from_stats() when calculating image_stats. It also fixed #349, where image_stats in the PyOPIA netcdf is missing metadata to required to make it self-describing (e.g. units and long_name) and CF-compatible (e.g. standard_name).