Handle out-of-bounds coordinates during evaluation#259
Open
Sichao25 wants to merge 2 commits intoSCOREC:developfrom
Open
Handle out-of-bounds coordinates during evaluation#259Sichao25 wants to merge 2 commits intoSCOREC:developfrom
Sichao25 wants to merge 2 commits intoSCOREC:developfrom
Conversation
Collaborator
|
@hgangwar please review this when you get a chance. Changes here are what we discussed about handling points outside the domain. |
jacobmerson
requested changes
Feb 15, 2026
| { | ||
| ERROR, // Throw error when points are out of bounds | ||
| FILL, // Fill out-of-bounds points with a fill value | ||
| CLAMP // Clamp to nearest boundary cell (extrapolate) |
Collaborator
There was a problem hiding this comment.
Can we call this NEAREST_BOUNDARY? Clamp means "saturate" to some high or low value. Such as: https://en.cppreference.com/w/cpp/algorithm/clamp.html
|
|
||
| for (size_t i = 0; i < search_results.size(); ++i) { | ||
| auto [dim, elem_idx, coord] = search_results(i); | ||
| bool is_valid = (static_cast<int>(dim) == mesh.dim()) && |
Collaborator
There was a problem hiding this comment.
Just check if the index is negative. A negative index means the point is outside.
| num_missing_ = missing_point_indices.size(); | ||
|
|
||
| // Handle missing points based on mode | ||
| if (num_missing_ > 0 && mode_ == OutOfBoundsMode::ERROR) { |
Collaborator
There was a problem hiding this comment.
rather than waiting to process points, let's throw an error as soon as you get an invalid point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle out-of-bounds cases by throwing an exception or filling a given value. CLAMP mode (map to nearest elements) is not yet implemented.