Add PTB HLT and LLT information to CAF files for real SBND data#614
Add PTB HLT and LLT information to CAF files for real SBND data#614
Conversation
fjnicolas
left a comment
There was a problem hiding this comment.
Looks great @hbjamin! See comment in SBNSoftware/sbnanaobj#180 about uint64_t for the decoded HLT/LLT IDs
PetrilloAtWork
left a comment
There was a problem hiding this comment.
I have dropped a few technical suggestions.
But more importantly I would like the author to deeply think about the real need for a catch(...) in the code.
|
Thank you for the good suggestions. There was no reason for me to use a catch statement. It was leftover from my initial debugging of |
|
Thanks @hbjamin ! @PetrilloAtWork , do the changes look good to you? Thanks! |
|
Bumping this, if @PetrilloAtWork is happy we should merge this. Thanks! |
PetrilloAtWork
left a comment
There was a problem hiding this comment.
I am going to approve the PR as I suppose that's "urgently" needed.
However, I invite the author to rethink the pattern and to update it: here we have a direct extraction from raw detector-specific data to the highest analysis level. That is a very strong coupling.
My recommendation is to move the extraction code into sbndcode producer module which puts the extracted information into a data product (std::vector<PTBInfo_t>), allowing CAF maker and anything else to access it without the need for artDAQ and the knowledge of low-level details on the data format.
|
Hi @maxdubnowski @nathanielerowe! This PR involves some changes to the POTTools and the POT exposure accounting modules. Could you please have a look/approve if these look good to you? Thanks! |
|
I don't understand some of the changes being made here. Why are we moving around factors in the data products? Was there a unit change somewhere? |
Hi @nathanielerowe the |
|
@hbjamin Gotcha, checking that it doesn't change the POT results now. Are these changes also made to the decoder module? A lot of the PTB product parsing code was copied from there. |
|
Distributions match, looks good on my end! |
nathanielerowe
left a comment
There was a problem hiding this comment.
Could maybe move extractAllPTBInfo elsewhere since it doesn't actually get used in the POT process, but fine if it stays!
Description
This PR adds PTB information to CAF files for real SBND data, which is required for trigger efficiency studies using zero bias data. The implementation extracts all HLT (High Level Trigger) and LLT (Low Level Trigger) information from PTB fragments, decodes trigger words into individual bits, and stores them separately in the CAF structure. This PR requires merging SBNSoftware/sbnanaobj#180