Destination DuckDB should not have access to parquet files#81
Merged
Conversation
stefpiatek
approved these changes
Feb 27, 2026
tests/utils.py
Outdated
Comment on lines
+197
to
+198
| # duckdb_con = duckdb.connect(self._db_path) | ||
| # duckdb_con.close() |
Collaborator
Author
There was a problem hiding this comment.
Oh yeah, I was trying to simplify because DuckDB was getting a bit pernickety about what was open and what wasn't, and I wondered if I could do without it. Turned out I could; just forgot to delete it!
Comment on lines
+231
to
+234
| "config": { | ||
| "enable_external_access": False, | ||
| } | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datafaker explicitly asks for destination database access.
Destination database access to a DuckDB database refuses Parquet file access.
Writing the tests was the hard part!